Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Make matMul accept mismatching batch dimensions when one input has batch 1. #3917

Merged
merged 15 commits into from
Oct 20, 2020

Conversation

annxingyuan
Copy link
Collaborator

@annxingyuan annxingyuan commented Sep 14, 2020

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Reviewable status: 0 of 1 approvals obtained (waiting on @annxingyuan and @pyu10055)


tfjs-core/src/ops/mat_mul_test.ts, line 79 at r1 (raw file):

    const c = tf.matMul(a, b);
    const data = await c.data();
    console.log(Array.from(data));

remove log


tfjs-core/src/ops/mat_mul_test.ts, line 82 at r1 (raw file):

    // expect(c.shape).toEqual([1, 2, 2, 3, 1]);
  });
  // fit('unequal ranks', async () => {

should this test be enabled?

@annxingyuan annxingyuan marked this pull request as ready for review October 19, 2020 17:48
@annxingyuan annxingyuan self-assigned this Oct 19, 2020
@annxingyuan
Copy link
Collaborator Author

Sorry guys - I somehow accidentally merged this... but I reverted it (70c823f).

Here's a new PR with the same code: #4100

Really sorry for the confusion - I think I had this window open for a while and then was trying to look at build logs but the window wasn't responding so I clicked a few times and then somehow merged... it's never happened before - I think I just need to refresh github windows that have been open for a while from now on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants