-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Make matMul accept mismatching batch dimensions when one input has batch 1. #3917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reviewable status: 0 of 1 approvals obtained (waiting on @annxingyuan and @pyu10055)
tfjs-core/src/ops/mat_mul_test.ts, line 79 at r1 (raw file):
const c = tf.matMul(a, b); const data = await c.data(); console.log(Array.from(data));
remove log
tfjs-core/src/ops/mat_mul_test.ts, line 82 at r1 (raw file):
// expect(c.shape).toEqual([1, 2, 2, 3, 1]); }); // fit('unequal ranks', async () => {
should this test be enabled?
Sorry guys - I somehow accidentally merged this... but I reverted it (70c823f). Here's a new PR with the same code: #4100 Really sorry for the confusion - I think I had this window open for a while and then was trying to look at build logs but the window wasn't responding so I clicked a few times and then somehow merged... it's never happened before - I think I just need to refresh github windows that have been open for a while from now on... |
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)