Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up builds. #4072

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Speed up builds. #4072

merged 1 commit into from
Oct 14, 2020

Conversation

lina128
Copy link
Collaborator

@lina128 lina128 commented Oct 14, 2020

Changes in this PR includes:

  1. Remove redundant test conditions in webgl.
  2. Layers tests with both firefox and chrome every PR, use chrome should be sufficient.
  3. Node and NodeGpu takes too much time to build deps (~9mins), upgrade to a more powerful computation unit.

After test:

  • Node and NodeGpu reduced 3 mins.
  • Layers and Webgl is mainly saving some browserstack resources.

This change is Reviewable

Copy link
Contributor

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 HIGHCPU to the rescue!

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pyu10055 and @tafsiri)

@tafsiri
Copy link
Contributor

tafsiri commented Oct 14, 2020

A suggestion, should we also use HIGHCPU on the union package cloudbuild since it builds the converter in its build-deps (and generally has a lot of deps)?

@tafsiri
Copy link
Contributor

tafsiri commented Oct 14, 2020

Also just for my own understanding which timing are you looking at for the 1-2 min for node/node-gpu? (i tried looking at the logs/build gui for the checks on this PR but didn't see it (or wasn't exactly sure which item you are referring to).

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @pyu10055)

Copy link
Collaborator Author

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the duration, for this PR it is 6min, for a previous PR it is 9min, also for nightly it is 9min., just changed the description it should be 3 mins improvement! Yeah, HIGHCPU to the rescue! Btw, I found the timing on the left panel less useful, because it includes waiting time.

Will add HIGHCPU to union package in a separate PR. Nice catch!

Reviewable status: :shipit: complete! 2 of 1 approvals obtained

@lina128 lina128 merged commit faeb388 into tensorflow:master Oct 14, 2020
@lina128 lina128 added this to In progress in Test Infra Redesign via automation Oct 14, 2020
@lina128 lina128 moved this from In progress to Done in Test Infra Redesign Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants