-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up builds. #4072
Speed up builds. #4072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 HIGHCPU to the rescue!
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @pyu10055 and @tafsiri)
A suggestion, should we also use HIGHCPU on the union package cloudbuild since it builds the converter in its build-deps (and generally has a lot of deps)? |
Also just for my own understanding which timing are you looking at for the 1-2 min for node/node-gpu? (i tried looking at the logs/build gui for the checks on this PR but didn't see it (or wasn't exactly sure which item you are referring to). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @pyu10055)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the duration, for this PR it is 6min, for a previous PR it is 9min, also for nightly it is 9min., just changed the description it should be 3 mins improvement! Yeah, HIGHCPU to the rescue! Btw, I found the timing on the left panel less useful, because it includes waiting time.
Will add HIGHCPU to union package in a separate PR. Nice catch!
Reviewable status:
complete! 2 of 1 approvals obtained
Changes in this PR includes:
After test:
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)