-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize node backend kernels #4119
Conversation
LogicalAnd, LogicalNot, LogicalOr, Max
Prod, Add, AddN, ArgMax, ArdMin, Diag, Equal, FloorDiv, Maximum, Min, Minimum, Multiple, NotEqual, Sum, UnsortedSegmentSum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yannick! LGTM
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @jinjingforever, @lina128, and @tafsiri)
tfjs-node/src/register_all_kernels.ts, line 90 at r1 (raw file):
for (const kernelConfig of kernelConfigs) { console.log('registering kernel', kernelConfig.kernelName);
Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @jinjingforever and @lina128)
tfjs-node/src/register_all_kernels.ts, line 90 at r1 (raw file):
Previously, jinjingforever (Jing Jin) wrote…
Remove?
Good catch. Removed!
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)