Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Fix bundler config and change module entry point in package.json. #4121

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

annxingyuan
Copy link
Collaborator

@annxingyuan annxingyuan commented Oct 23, 2020

This fixes #4107

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@google-cla google-cla bot added the cla: yes label Oct 23, 2020
@annxingyuan annxingyuan self-assigned this Oct 23, 2020
@annxingyuan annxingyuan changed the title [wasm] Fix bundler config. [wasm] Fix bundler config and change module entry point in package.json. Oct 23, 2020
Copy link
Contributor

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @tafsiri)

@annxingyuan annxingyuan merged commit 83f5004 into master Oct 23, 2020
@annxingyuan annxingyuan deleted the wasm_starter branch October 23, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] worker.js onmessage() captured an uncaught exception:Uncaught ReferenceError: t is not defined
2 participants