Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modularize complex kernels in node #4220

Merged
merged 5 commits into from Nov 16, 2020
Merged

modularize complex kernels in node #4220

merged 5 commits into from Nov 16, 2020

Conversation

tafsiri
Copy link
Contributor

@tafsiri tafsiri commented Nov 11, 2020

Also refactors the CPU abs kernel to split into Abs and ComplexAbs.

Modularizes: complex, real, imag, fft, ifft, complexAbs

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@google-cla google-cla bot added the cla: yes label Nov 11, 2020
@tafsiri tafsiri marked this pull request as ready for review November 11, 2020 16:18
Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @lina128, and @tafsiri)


tfjs-backend-cpu/src/kernels/Abs.ts, line 31 at r1 (raw file):

export const abs = (args: {inputs: AbsInputs, backend: MathBackendCPU}) => {
  const {x} = args.inputs;

assertNotComplex?

@tafsiri
Copy link
Contributor Author

tafsiri commented Nov 16, 2020

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @lina128, and @tafsiri)

tfjs-backend-cpu/src/kernels/Abs.ts, line 31 at r1 (raw file):

export const abs = (args: {inputs: AbsInputs, backend: MathBackendCPU}) => {
  const {x} = args.inputs;

assertNotComplex?

Done (couldn't access reviewable atm)

@tafsiri tafsiri merged commit 9460c78 into master Nov 16, 2020
@tafsiri tafsiri deleted the mod-node-13 branch November 16, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants