Fix wasm strided slice with new axis #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvanhaes
force-pushed
the
fix-wasm-strided-slice
branch
from
19846fb
to
46be2a9
Compare
pvanhaes
force-pushed
the
fix-wasm-strided-slice
branch
from
46be2a9
to
e50f1dc
Compare
pyu10055
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
Thanks for the contribution.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see this small fix for the wasm implementation of strided slice.
In nonStrided mode with new axes, the output tensor would contain NaNs.
The updated test now covers this case as well.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is