[webgl] Add default arguments to CropAndResize. #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lina128
reviewed
Dec 15, 2020
There was a problem hiding this comment.
Hi Ann, can you add these two lines in webgl kernel CropAndResize, similar as in cpu kernel:
const $method = method || 'bilinear';
const $extrapolationValue = extrapolationValue || 0;
Reviewable status: 0 of 1 approvals obtained (waiting on @lina128)
lina128
reviewed
Dec 15, 2020
There was a problem hiding this comment.
Also, add a test for method is null and extrapolationValue is null.
Reviewable status: 0 of 1 approvals obtained
annxingyuan
changed the title
annxingyuan
commented
Dec 16, 2020
There was a problem hiding this comment.
Done - please take another look.
Reviewable status: 0 of 1 approvals obtained
lina128
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Thank you Ann!
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @lina128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think they were unintentionally removed by #4265
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is