[webgl] Fixed split issue with negative axis. #4478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BruceDai thanks for this, the change looks good but it would be great to have a test with a negative axes param to catch regressions across backends. Would you be able to add one to split_test.ts? |
lina128
reviewed
Jan 6, 2021
There was a problem hiding this comment.
Nice catch, thank you Bruce! LGTM. +1 to Yannick's suggestion.
Reviewable status: 0 of 1 approvals obtained
|
The test failed because of this line, can you also update this line to use $axis? https://github.com/tensorflow/tfjs/blob/master/tfjs-backend-wasm/src/kernels/SplitV.ts#L33 |
|
@lina128 Done. PTAL, thanks. |
lina128
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Thank you! LGTM
Reviewable status:
complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is