[wasm] Implement the Round kernel #4486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Matt! Sorry if I've misunderstood, but it seems like our CPU / WebGL backends both use banker's rounding as well? Could you confirm that they boil down to the same algorithm? If so then this PR looks great - if not then I would avoid using XNNPACK and implement the kernel by hand. |
|
I should have checked CPU and WebGL first. They also use banker's rounding, so this PR's implementation should be fine. |
annxingyuan
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the Round kernel using XNNPACK's banker's rounding. Banker's rounding rounds to the nearest integer, but breaks ties in the direction of the nearest even integer. It passes our tests, but might not be desirable. XNNPACK doesn't seem to expose a 'normal' rounding operator that always rounds up in the case of a tie.
Closes #4434
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is