Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add return type for kernelNames getter #4582

Merged
merged 2 commits into from Jan 21, 2021
Merged

add return type for kernelNames getter #4582

merged 2 commits into from Jan 21, 2021

Conversation

tafsiri
Copy link
Contributor

@tafsiri tafsiri commented Jan 20, 2021

resolves a g3 import warning

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

resolves a g3 import warning
Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@mattsoulanille
Copy link
Member

Thanks! I remember doing this for the 2.8.4 sync, but I forgot to make a PR into GitHub.

@tafsiri tafsiri changed the title add return type for getter add return type for kernelNames getter Jan 21, 2021
@tafsiri tafsiri merged commit 7daf406 into master Jan 21, 2021
@tafsiri tafsiri deleted the tafsiri-patch-1 branch January 21, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants