Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[webgl] Texture to tensor API. (#4376)" #4675

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Revert "[webgl] Texture to tensor API. (#4376)" #4675

merged 1 commit into from
Feb 12, 2021

Conversation

mattsoulanille
Copy link
Member

@mattsoulanille mattsoulanille commented Feb 12, 2021 •
edited by nsthorat
Loading

This reverts commit 65dcfcc, which is failing on Mobile Safari in nightly tests.

Mobile Safari 11.0.0 (iOS 11.2.0) create tensor from texture webgl1 {"WEBGL_VERSION":1,"WEBGL_CPU_FORWARD":false,"WEBGL_SIZE_UPLOAD_UNIFORM":0} basic usage FAILED
	Error: The textureType must be 36193. in /tmp/karma-typescript-bundle--163-OZsx3WJLYu4d-.js (line 166939)
	assert@/tmp/karma-typescript-bundle--163-OZsx3WJLYu4d-.js:166939:24
	createTensorFromTexture@src/webgl.ts:150:14 <- src/webgl.js:125:28
	src/backend_webgl_test.ts:288:38 <- src/backend_webgl_test.js:296:55
	step@src/backend_webgl_test.js:48:27
	src/backend_webgl_test.js:23:75
	<Jasmine>
	src/backend_webgl_test.js:19:36
	<Jasmine>

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

@google-cla google-cla bot added the cla: yes label Feb 12, 2021
@pyu10055
Copy link
Collaborator

cc @annxingyuan Rolling back this PR since it is failing the nightly. Thanks

pyu10055
pyu10055 approved these changes Feb 12, 2021
View reviewed changes
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan)

@mattsoulanille mattsoulanille merged commit 1612c9a into tensorflow:master Feb 12, 2021
@mmetelskiy mmetelskiy mentioned this pull request Mar 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyu10055 pyu10055 pyu10055 approved these changes

@annxingyuan annxingyuan Awaiting requested review from annxingyuan

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattsoulanille @pyu10055