Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfiles to support emsdk #4772

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

mattsoulanille
Copy link
Member

@mattsoulanille mattsoulanille commented Mar 2, 2021

Update dockerfiles to support Emscripten's official Bazel toolchain, which #4769 adds.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@mattsoulanille
Copy link
Member Author

I've tested building the containers locally, and I've built parts of tfjs with them, but I haven't done a full rebuild. I don't expect these changes to break anything since they only add new dependencies to the dockerfiles.

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @mattsoulanille)


dockers/wasm-docker/Dockerfile, line 8 at r1 (raw file):

RUN apt-get update -qqy && apt-get install -qqy \
        curl \

Do you need all of this? Better to just pick the ones you need. Otherwise, it increases docker building time at the beginning of each CI run.


dockers/wasm-docker/Dockerfile, line 21 at r1 (raw file):

pip3 install -U absl-py

Can you follow the same style as the release docker:

# Install absl
RUN pip3 install -U absl-py

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @mattsoulanille)

@lina128 lina128 merged commit 1f11f74 into tensorflow:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants