Fuse depthwise conv2d with activation function without biasAdd #4910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he accuracy issue, enabled the flag by default
lina128
reviewed
Apr 8, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)
tfjs-converter/src/operations/executors/convolution_executor.ts, line 34 at r1 (raw file):
const isBiasAdd = extraOp === 'biasadd'; const noBiasAdd = extraOp === 'noop';
Why noBiasAdd can't be !isBiasAdd?
pyu10055
commented
Apr 16, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @lina128)
tfjs-converter/src/operations/executors/convolution_executor.ts, line 34 at r1 (raw file):
Previously, lina128 (Na Li) wrote…
Why
noBiasAddcan't be!isBiasAdd?
Done.
lina128
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @lina128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows depthwise conv2d without biasAdd to fuse with activation
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is