Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate code coverage reports for packages #4946

Merged
merged 16 commits into from Apr 28, 2021

Conversation

mattsoulanille
Copy link
Member

@mattsoulanille mattsoulanille commented Apr 16, 2021

Add a yarn coverage command to packages to generate coverage reports.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@google-cla google-cla bot added the cla: yes label Apr 16, 2021
@mattsoulanille mattsoulanille marked this pull request as ready for review April 28, 2021 20:49
Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Matt. Just for my understanding, we need to run yarn coverage in local, right? Is it possible to automate test coverage in nightly?

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@mattsoulanille
Copy link
Member Author

Thanks for the review, Na! Currently, we have to run yarn coverage in local. I'm still working on automating this, but with these changes merged, we'll at least be able to run coverage from this point forward in the repo's history for future coverage reports.

@mattsoulanille mattsoulanille merged commit b0fd011 into tensorflow:master Apr 28, 2021
@mattsoulanille mattsoulanille deleted the coverage branch April 28, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants