depthwise packed perf: reduce texel read for dilation of 2 #4954
Conversation
pyu10055
changed the title
There was a problem hiding this comment.
This looks great. Curious, how much overhead is saved by reusing the same vertex shader?
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @pyu10055)
tfjs-backend-webgl/src/conv_packed_gpu_depthwise.ts, line 78 at r1 (raw file):
`; for (let texelC = 0; texelC < (texelsAcross + 1) / 2; texelC++) {
Just want to confirm this change changes the loop rounds, for example, if texelsAcross = 4, before was texelC < 3, now is texelC < 2.
There was a problem hiding this comment.
Unfortunately, there seems to be very minimal saving on the first inference.
Reviewable status:
tfjs-backend-webgl/src/conv_packed_gpu_depthwise.ts, line 78 at r1 (raw file):
Previously, lina128 (Na Li) wrote…
Just want to confirm this change changes the loop rounds, for example, if texelsAcross = 4, before was texelC < 3, now is texelC < 2.
yes, used to generate extra loops that is not doing anything. Since in each loop it generates two values.
Use flag to record if the texel has be read and ready to be reused. This would minimize unnecessary reading for all conditions.
Aligned the texel naming with the index.
reuse the same vertex shader for all GPGPU programs.
Verified the result of this change with the ssd colab.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is