Make tfjs-node create a new TFJSBackend for each environment #5108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #4947.
tfjs-node
assumes a single globalTFJSBackend
for allnapi_env
s. This assumption holds for most applications, but not when embedding node in C++ with multiple environments or when using web workers. The user observes typical non-deterministic behavior with random crashes and weird error messages.To resolve this, a map is created that holds a
TFJSBackend
for eachnapi_env
.Cleanup wasn't handled by the previous global implementation, so it's also not handled by this implementation. This may be undesirable. I also did this quickly to fix an issue I was having with little regard for style, DRYness, or other considerations, so hope it's a useful starting point for a project developer at least.
This change is