Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow string inputs in gatherND #5157

Merged
merged 1 commit into from Jun 1, 2021
Merged

Allow string inputs in gatherND #5157

merged 1 commit into from Jun 1, 2021

Conversation

ahmedsabie
Copy link
Contributor

@ahmedsabie ahmedsabie commented Jun 1, 2021 •
edited by nsthorat

ref #4838

The model in the referred issue requires using gatherND with a string input

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

@ahmedsabie ahmedsabie requested a review from pyu10055 June 1, 2021 20:48
@google-cla google-cla bot added the cla: yes label Jun 1, 2021
pyu10055
pyu10055 approved these changes Jun 1, 2021
View reviewed changes
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ahmedsabie ahmedsabie merged commit 1204d43 into tensorflow:master Jun 1, 2021
@ahmedsabie ahmedsabie deleted the gathernd-string branch June 1, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyu10055 pyu10055 pyu10055 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahmedsabie @pyu10055