Unpack input in ArgMin/Max WebGL kernel #5437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lina128
reviewed
Aug 6, 2021
There was a problem hiding this comment.
Thank you Ahmed, have you benchmarked the performance change? How much time does it reduce?
Reviewable status: 0 of 1 approvals obtained
|
Unpack is pretty fast so the saving is mostly having less shader calls, I see around 0.2ms per call and there's around log(log(N)) calls to it where N Is last dimension of input. |
lina128
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Thanks for the info.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @pyu10055)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents each shader from having to unpack the input again due to lazy unpacking
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is