Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webgpu] Fix clipByValue vec4 error #5511

Merged
merged 2 commits into from Aug 22, 2021
Merged

[webgpu] Fix clipByValue vec4 error #5511

merged 2 commits into from Aug 22, 2021

Conversation

axinging
Copy link
Contributor

@axinging axinging commented Aug 20, 2021 •
edited by nsthorat

Fix unit test basic vec4 fail.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

@axinging
[webgpu] Fix clipByValue vec4 error
5fa4b6c 
Fix unit test basic vec4 fail.
@google-cla google-cla bot added the cla: yes label Aug 20, 2021
@axinging
Copy link
Contributor Author

@qjia7 @haoyunfeix @Xchao @gyagp， PTAL

qjia7
qjia7 approved these changes Aug 20, 2021
View reviewed changes
Copy link
Collaborator

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kainino0x @lina128 take a look, thanks.

@qjia7 qjia7 merged commit b77c379 into tensorflow:master Aug 22, 2021
@axinging axinging deleted the fix_basicvec4 branch September 22, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kainino0x kainino0x kainino0x approved these changes

@qjia7 qjia7 qjia7 approved these changes

@lina128 lina128 Awaiting requested review from lina128

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@axinging @kainino0x @qjia7