[wasm] Fix offset calculation in Conv2DBackpropInput #5518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now the program submitted by the user in #5390 works well with the WASM backend:
|
pyu10055
reviewed
Aug 21, 2021
There was a problem hiding this comment.
Thanks for debugging and fixing the problem, FYI you new test seems to cause tfjs-node implementation to fail.
Reviewable status: 0 of 1 approvals obtained
jinjingforever
commented
Aug 23, 2021
There was a problem hiding this comment.
Updated test which works in tfjs-node. Also double checked that the test would fail before this PR for the WASM backend. Also updated package.json in tfjs-node.
Reviewable status: 0 of 1 approvals obtained
pyu10055
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation didn't take into account of various stride values. Fixed now (based on CPU implementation).
Also added a test to cover the case where inDepth is not 1 (which will trigger the bug).
Fixes #5390
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is