Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix for the NamedTensorInfoMap type. #5523

Merged
merged 1 commit into from Aug 23, 2021
Merged

Minor fix for the NamedTensorInfoMap type. #5523

merged 1 commit into from Aug 23, 2021

Conversation

jinjingforever
Copy link
Collaborator

@jinjingforever jinjingforever commented Aug 23, 2021

Without this, the build would fail in Angular apps that use typescript 4+ which has more strict check.

The failed code:

export interface FusedConv2DInputs extends NamedTensorInfoMap {
  x: TensorInfo;
  filter: TensorInfo;
  bias?: TensorInfo;  // <--- Error: Property 'bias' of type 'TensorInfo | undefined' is not assignable to string index type 'TensorInfo'.
  preluActivationWeights?: TensorInfo;  // <--- Same error
}

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@pyu10055 pyu10055 merged commit 49f9c73 into master Aug 23, 2021
@pyu10055 pyu10055 deleted the fixtype branch August 23, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants