[DRAFT] Update TypeScript to 4.4.2

[mattsoulanille]

This PR updates TypeScript from 3.5.3 to 4.4.2. It is still a work in progress:

• tfjs-converter: Tests need to be rewritten to avoid spying on properties of imported objects This is done.
• tfjs-vis: There's a test failure with TypeScript 4.4.2: This is now fixed

Chrome 92.0.4515.159 (Linux x86_64) perClassAccuracy renders histogram FAILED
	Error: Expected 0 to be 1.
	    at <Jasmine>
	    at src/show/tensor_test.ts:32:61 <- src/show/tensor_test.js:58:65
	    at Generator.next (<anonymous>)
	    at fulfilled (src/show/tensor_test.js:40:58)

• tfjs (union package): Depends on converter
• tfjs-node(-gpu), e2e: Depends on tfjs union.
• tfjs-backend-webgpu: Done.
• tfjs-react-native: Haven't tried this package yet.

These changes will let us add the useUnknownInCatchVariables and noImplicitOverride flags to the tsconfig (in a separate PR).

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

---

This change is 

[pyu10055]

Thank you so much for go through this and get our code to be ts 4 compatible.

Reviewed 2 of 3 files at r2, 2 of 2 files at r3, 3 of 3 files at r4, 2 of 2 files at r5, 2 of 2 files at r6, 6 of 7 files at r7, 2 of 2 files at r8, 2 of 2 files at r9, 2 of 2 files at r10, 33 of 41 files at r11, 2 of 2 files at r12, 1 of 2 files at r13, 16 of 16 files at r15, 3 of 3 files at r16, 2 of 2 files at r17, 4 of 4 files at r18, 4 of 4 files at r19, 2 of 2 files at r20, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @mattsoulanille)

---

tfjs-converter/src/operations/executors/dynamic_executor.ts, line 53 at r20 (raw file):

export const executeOp: InternalOpAsyncExecutor = async(
    node: Node, tensorMap: NamedTensorsMap,
    context: ExecutionContext, _resourceManager,

why the _resourceManager starts with _, should the _resourceManager to have a type?

---

tfjs-data/src/iterators/microphone_iterator_test.ts, line 34 at r20 (raw file):

      const result = await microphoneIterator.next();
      expect(result.done).toBeFalsy();
      // tslint:disable-next-line:no-any

the any lint ignore should be removed, also apply for the cases in rest of the file.

[mattsoulanille]

Thanks for the review!

I've discovered that this is a breaking change for typescript 3.5 users. When I try to compile an app that depends on tfjs-core and backend-cpu that uses TypeScript 3.5.3, I see the following:

node_modules/@tensorflow/tfjs-core/dist/engine.d.ts:127:9 - error TS1086: An accessor cannot be declared in an ambient context.

127     get backend(): KernelBackend;
            ~~~~~~~
...

Compiling the downstream app with TS 3.7 and above results in no issues. Should we release this with version 4.0.0?

Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)

---

tfjs-converter/src/operations/executors/dynamic_executor.ts, line 53 at r20 (raw file):

Previously, pyu10055 (Ping Yu) wrote…

why the _resourceManager starts with _, should the _resourceManager to have a type?

I put an underscore in front of resourceManager because it's unused, but that's actually against the style guide. Fixed.

I also added its type, although we could actually remove the types from all these function arguments since they are specified by InternalOpAsyncExecutor (although I'm not sure if this would be against the style guide).

---

tfjs-data/src/iterators/microphone_iterator_test.ts, line 34 at r20 (raw file):

Previously, pyu10055 (Ping Yu) wrote…

the any lint ignore should be removed, also apply for the cases in rest of the file.

Done.

[pyu10055]

I agree if it is breaking for 3.5.x, we should either figure out a work around, or do a major release.

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @pyu10055)

[pyu10055]

not sure if this is the solution:
storybookjs/storybook#9463

can you try readonly hackend(): KernelBackend;?

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @pyu10055)

[mattsoulanille]

Unfortunately, that solution only works if you're providing manually written declaration files, since it requires editing them.

This might not be a hugely breaking change. Users can upgrade to 3.6.2, which has fewer breaking changes from 3.5.3 than 3.7 has. Alternatively, they can add skipLibCheck: true to their tsconfigs, which isn't recommended but does fix / hide the issue.

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @pyu10055)

[pyu10055]

Reviewed 1 of 1 files at r21.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @pyu10055)

[mattsoulanille]

Superseded by #6346.