webgpu: Remove glsl code #5654
Merged
webgpu: Remove glsl code #5654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@axinging @xhcao @haoyunfeix PTAL |
|
@lina128 Do you know why removing WEBGPU_USE_GLSL from benchmarks fails? |
gyagp
reviewed
Sep 23, 2021
| } | ||
|
|
||
| getUserCode(): string { | ||
| getUserCodeWgsl(): string { |
There was a problem hiding this comment.
Don't include wgsl in name.
| `; | ||
| return userCode; | ||
| } | ||
|
|
||
| getUserCodeWgsl(): string { |
There was a problem hiding this comment.
Could we unify the function name to getUserCode?
| pipelineLayout: GPUPipelineLayout, | ||
| inputsData: shader_preprocessor.InputInfo[], output: TensorInfo, | ||
| inputsData: shader_preprocessor_wgsl.InputInfo[], output: TensorInfo, |
lina128
reviewed
Sep 23, 2021
There was a problem hiding this comment.
Hi Jiajia, I haven't dig deep into this, just some ideas here, did you generate new bundle and reference the local bundle in your benchmark tool?
Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055 and @qjia7)
lina128
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @pyu10055 and @qjia7)
|
LGTM with nit: please remove glsl_version.ts |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is