[webgl] Fix nightly browser configurations #5687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyu10055
requested changes
Oct 1, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @mattsoulanille)
tfjs-backend-webgl/BUILD.bazel, line 130 at r2 (raw file):
"bs_firefox_mac", "bs_safari_mac", "bs_ios_11",
do we need to test webgl1 on non-ios browsers ?
pyu10055
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @mattsoulanille)
mattsoulanille
commented
Oct 1, 2021
There was a problem hiding this comment.
Reviewable status:
tfjs-backend-webgl/BUILD.bazel, line 130 at r2 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
do we need to test webgl1 on non-ios browsers ?
I don't think so. Removed them.
pyu10055
pushed a commit
that referenced
this pull request
Oct 13, 2021
Run the correct browsers in nightly and pass the correct parameters to them to match the original test-ci.sh file. Pin Firefox to 90. Fix square test comparison precision on Safari webgl1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the correct browsers in nightly and pass the correct parameters to them to match the original test-ci.sh file.
Pin Firefox to 90.
Fix
squaretest comparison precision on Safari webgl1.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is