Add SparseReshape kernel to WASM backend #5723
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @ahmedsabie)
tfjs-core/src/ops/sparse/sparse_reshape_test.ts, line 69 at r1 (raw file):
])).toThrowError(/multiple of 7/); }); it('throw error if negative output dim', async () => {
can you add a memory leak check test? thanks
tfjs-core/src/ops/sparse/sparse_reshape_util.ts, line 3 at r1 (raw file):
/** * @license * Copyright 2018 Google LLC. All Rights Reserved.
2021
tfjs-core/src/ops/sparse/sparse_reshape_util.ts, line 23 at r1 (raw file):
* * @param dim1 The first dimension with a negative 1 value. * @param dim2 The second dimension with a negative 1 value..
there is an extra period in the doc for the second param.
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)
tfjs-core/src/ops/sparse/sparse_reshape_test.ts, line 69 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
can you add a memory leak check test? thanks
Done.
tfjs-core/src/ops/sparse/sparse_reshape_util.ts, line 3 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
2021
Done.
tfjs-core/src/ops/sparse/sparse_reshape_util.ts, line 23 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
there is an extra period in the doc for the second param.
Done.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is