Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint errors #5783

Merged
merged 1 commit into from Oct 27, 2021
Merged

Fix lint errors #5783

merged 1 commit into from Oct 27, 2021

Conversation

jinjingforever
Copy link
Collaborator

@jinjingforever jinjingforever commented Oct 27, 2021 •
edited by nsthorat

  • Removed the import of log in environment.ts to remove circular dependency.
  • Reformatted some other files to fix lint errors (exceeds maximum line length, missing semicolon, etc).

Now yarn lint returns no errors.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

@google-cla google-cla bot added the cla: yes label Oct 27, 2021
@jinjingforever jinjingforever merged commit 1466e0c into master Oct 27, 2021
@jinjingforever jinjingforever deleted the fixcore branch October 27, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyu10055 pyu10055 pyu10055 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jinjingforever @pyu10055