Fix Apple silicon WASM development #6098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsoulanille
added a commit
that referenced
this pull request
Feb 4, 2022
Upgrade Bazel version to 4.2.2 (supported by m1), rules_nodejs to 4.6.1 (required for node 16.13.2), and node to 16.13.2 (same as our CI docker image and required for m1 compatibility). tfjs-backend-wasm will be fixed in #6098. Not yet working: * tfjs-converter python. #6089 may fix this if you have a working python2.7 homebrew install.
mattsoulanille
force-pushed
the
fix_m1_wasm_dev
branch
from
f915dac
to
e854634
Compare
mattsoulanille
commented
Feb 12, 2022
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained
tfjs-backend-wasm/src/cc/BUILD, line 64 at r1 (raw file):
"-s MALLOC=emmalloc", "-s USE_PTHREADS=1", "-s PROXY_TO_PTHREAD=1",
I removed this because I don't think it's actually doing anything for us. We have no main function, so there's nothing to proxy, at least according to the emscripten error message I get when I compile with this flag:
emcc: error: PROXY_TO_PTHREAD proxies main() for you, but no main exists
Code quote:
"-s PROXY_TO_PTHREAD=1",XNNPACK does not make guarantees about NaN propogation.
lina128
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Tested on my M1X, all tests passed. Thank you!
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @pyu10055)
pyu10055
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade xnnpack and emsdk to support WASM development on Apple silicon.
Depends on #6090. Also depends on emscripten-core/emsdk#978.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is