Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat properly HTTP URI to download tensorflow lib #6199

Merged

Conversation

danilosampaio
Copy link
Contributor

@danilosampaio danilosampaio commented Mar 4, 2022

The Install script allows to set a environment variable to download the tensorflow lib from a custom host (TFJS_NODE_BASE_URI). This PR treat properly the both protocols HTTP and HTTPS.

It fixes #6198


This change is Reviewable

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THank you for the contribution.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@pyu10055 pyu10055 merged commit b5420f8 into tensorflow:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install script can't download the tensorflow lib from a HTTP host
2 participants