Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tfjs-core] fix nightly #6306

Merged
merged 1 commit into from Apr 7, 2022
Merged

[tfjs-core] fix nightly #6306

merged 1 commit into from Apr 7, 2022

Conversation

pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented Apr 7, 2022

reduced the dy to avoid overflowing the webgl 1 float16 limitation for prod gradient. This fixes failing nightly.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@mattsoulanille mattsoulanille merged commit ca23135 into master Apr 7, 2022
@pyu10055 pyu10055 deleted the prod_gradient_fix branch April 8, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants