[node] Fix memory leak from string tensors #6371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsoulanille
force-pushed
the
node_string_memory_leak
branch
from
27cca02
to
44369a7
Compare
mattsoulanille
force-pushed
the
node_string_memory_leak
branch
from
44369a7
to
c006d85
Compare
jinjingforever
approved these changes
May 5, 2022
pyu10055
approved these changes
May 6, 2022
There was a problem hiding this comment.
Thank you for the fix
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where string tensor handles are deleted without the underlying tstrings being deallocated.
Fixes #5242
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is