webgpu: remove custom size parameter of dataToGPU #6393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qjia7 @haoyunfeix @axinging @gyagp, please take a look, thank you. |
qjia7
approved these changes
May 11, 2022
| @@ -381,6 +378,9 @@ export class Tensor<R extends Rank = Rank> { | |||
| * For WebGL backend, the data will be stored on a densely packed texture. | |||
| * This means that the texture will use the RGBA channels to store value. | |||
| * | |||
| * For WebGPU backend, the data will be stored on a buffer. There is no | |||
| * parameter, so can not use an user defined size to create the buffer. | |||
| * | |||
| * @param options: | |||
| * For WebGL, | |||
There was a problem hiding this comment.
@lina128 Do you know why this part of description is not presented in https://js.tensorflow.org/api/latest/#tf.Tensor.dataToGPU Returns: GPUData? Is there a bug here?
There was a problem hiding this comment.
Hi, @lina128 , Please take a look, especially review the issue asked by Jiajia, thank you.
lina128
approved these changes
May 16, 2022
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @qjia7)
tfjs-core/src/tensor.ts line 385 at r2 (raw file):
https://js.tensorflow.org/api/latest/#tf.Tensor.dataToGPU
Good catch! I just realized the returns field is not captured at all, not just this one. We'll fix it. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is