Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[secu] update package.json files to resolve security alerts #6448

Merged
merged 3 commits into from
May 25, 2022

Conversation

pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented May 25, 2022

Cleaned up the package.json files for directory migrated to bazel.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing all these unused packages! LGTM.

Reviewed 30 of 30 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @jinjingforever)


tfjs-backend-wasm/package.json line 71 at r2 (raw file):

    "karma-jasmine": "~1.1.1",
    "karma-typescript": "~5.5.1",
    "karma-typescript-es6-transform": "^5.0.2",

These are necessary because tfjs-backend-wasm still builds js and tests outside of Bazel even though it uses Bazel to run emscripten.

Code quote:

    "jasmine": "~3.1.0",
    "jasmine-core": "~3.1.0",
    "karma": "^6.3.16",
    "karma-browserstack-launcher": "~1.6.0",
    "karma-chrome-launcher": "~2.2.0",
    "karma-firefox-launcher": "~1.1.0",
    "karma-jasmine": "~1.1.1",
    "karma-typescript": "~5.5.1",
    "karma-typescript-es6-transform": "^5.0.2",

tfjs-node-gpu/package.json line 57 at r1 (raw file):

    "node-fetch": "~2.6.1",
    "node-gyp": "~5.0.3",
    "nyc": "^15.1.0",

note to self: node-gyp isn't necessary because node-pre-gyp wraps it.

Code quote:

    "node-gyp": "~5.0.3",

@mattsoulanille mattsoulanille merged commit 7e3c36a into master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants