[wasm] Add Object.fromEntries polyfill to tests to fix Safari 11 #6621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linchenn
approved these changes
Jul 14, 2022
|
According to the core-js readme, this polyfill should only apply in browsers that lack |
pyu10055
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained
|
Thank you Matt so much for researching on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari 11 does not support
Object.fromEntries, which is used in test_util.ts. Add a polyfill forObject.fromEntriesto the test suite to support testing on Safari 11 and set the target ECMAScript version to es6 in the test bundle.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is