Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect import path in center crop layer #6946

Merged
merged 1 commit into from Oct 14, 2022

Conversation

mattsoulanille
Copy link
Member

@mattsoulanille mattsoulanille commented Oct 14, 2022

center_crop.ts imported some dependencies from @tensorflow/tfjs-core/ops/.... This works in Bazel (not completely sure why), but is not standard and should be avoided.

Fixes #6944

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

`center_crop.ts` imported some dependencies from
`@tensorflow/tfjs-core/ops/...`. This works in Bazel (not completely sure why),
but is not standard and should be avoided.
Copy link
Collaborator

@Linchenn Linchenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Thank you Matt!

@mattsoulanille mattsoulanille merged commit ccf5482 into tensorflow:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression: unresolvable imports
3 participants