cleanup conv class definitions #6947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsoulanille
approved these changes
Oct 17, 2022
| @@ -706,7 +706,6 @@ serialization.registerClass(Conv3D); | |||
| export class Conv2DTranspose extends Conv2D { | |||
| /** @nocollapse */ | |||
| static className = 'Conv2DTranspose'; | |||
| inputSpec: InputSpec[]; | |||
There was a problem hiding this comment.
Nice catch. Note to other reviewer: This is declared in the Layer interface in src/engine/topology.ts.
| @@ -116,7 +116,7 @@ class ConvRNN2D extends RNN { | |||
| /** @nocollapse */ | |||
| static className = 'ConvRNN2D'; | |||
|
|
|||
| readonly cell: ConvRNN2DCell; | |||
| declare readonly cell: ConvRNN2DCell; | |||
There was a problem hiding this comment.
Nice catch here as well. cell is already a property of RNN, so declare is required here to assert its new type. I'm not completely sure why this didn't throw an error when compiling with Bazel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with
tfjs4.0 its almost there to a clean build using standardtscfew minor cleanups:
Conv2DTransposeandConv3DTransposeunnecessarily redeclareinputSpecwhen its already declared in parent classConvRNN2Dredeclarescellwith a different type than parent class, but without explicit declarationcc @mattsoulanille - can you take a look since you've done most of the work for
typescriptupgrade?This change is