Load tflite and tfdf wasm files with http_archive #7124
Merged
+140
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsoulanille
force-pushed
the
wasm_http_archive
branch
from
25afca6
to
b5d23df
Compare
pyu10055
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @Linchenn)
Linchenn
approved these changes
Nov 29, 2022
Linchenn
pushed a commit
to Linchenn/tfjs
that referenced
this pull request
Jan 9, 2023
tfjs-tfdf and tfjs-tflite both depend on pre-compiled WASM files. These WASM files are downloaded by scripts (i.e. curl) during the build step. This violates Bazel's hermeticity requirements because build steps should not access remote resources. This PR fixes this by downloading these WASM files using http_archive in the WORKSPACE file. Fixes tensorflow#7103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tfjs-tfdf and tfjs-tflite both depend on pre-compiled WASM files. These WASM files are downloaded by scripts (i.e.
curl) during the build step. This violates Bazel's hermeticity requirements because build steps should not access remote resources. This PR fixes this by downloading these WASM files usinghttp_archivein theWORKSPACEfile.Fixes #7103
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is