Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webgl: fix a typing nit #7199

Merged
merged 1 commit into from
Dec 25, 2022
Merged

webgl: fix a typing nit #7199

merged 1 commit into from
Dec 25, 2022

Conversation

xhcao
Copy link
Collaborator

@xhcao xhcao commented Dec 23, 2022 •
edited by dsmilkov

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

@xhcao xhcao requested a review from gyagp December 23, 2022 07:17
gyagp
gyagp approved these changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@gyagp gyagp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyagp
Copy link
Collaborator

gyagp commented Dec 23, 2022

@Linchenn @pyu10055 This is just a small coding style issue when @xhcao tried to borrow the code to WebGPU backend. PTAL

@Linchenn
Copy link
Collaborator

Thank you!

@Linchenn Linchenn self-requested a review December 25, 2022 20:08
@Linchenn Linchenn merged commit b6a5e25 into tensorflow:master Dec 25, 2022
Linchenn pushed a commit to Linchenn/tfjs that referenced this pull request Jan 9, 2023
@xhcao @Linchenn
webgl: fix a typing nit (tensorflow#7199)
8b27723 
DOC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyagp gyagp gyagp approved these changes

@Linchenn Linchenn Linchenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xhcao @gyagp @Linchenn