webgpu: upgrade webgpu/types #7528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shaoboyan Please take a look the changes in |
shaoboyan
reviewed
Mar 29, 2023
| fromPixels2DContext = | ||
| document.createElement('canvas').getContext( | ||
| '2d', {willReadFrequently}); | ||
| fromPixels2DContext = document.createElement('canvas').getContext( |
There was a problem hiding this comment.
Yes, it's automatically adjusted.
shaoboyan
approved these changes
Mar 29, 2023
xhcao
approved these changes
Mar 29, 2023
| backend.device.importExternalTexture(externalTextureDescriptor)); | ||
| } | ||
|
|
||
| const externalTextureDescriptor = {source: pixels as HTMLVideoElement}; |
There was a problem hiding this comment.
Nit: Remove externalTextureDescriptor, use backend.device.importExternalTexture({source: pixels as HTMLVideoElement})?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also uses the platform supported max buffer size, otherwise the limit is 256M.
Meanwhile, it removes expired which is not supported anymore.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is