Update node to 18.13.0 in Docker and Bazel #7585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use vm.runInNewContext for slightly better isolation. Switch the tf.util.fetch snippet's url from unpkg to jsdelivr since fetching the unpkg url using node fetch fails (maybe there's a robots.txt?).
pyu10055
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Reviewed 3 of 5 files at r1, 1 of 4 files at r2, 1 of 1 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @chunnienc)
mattsoulanille
requested review from
Linchenn
and removed request for
chunnienc
Linchenn
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, fix test snippets for node's builtin fetch function. Switch the
tf.util.fetchsnippet's url from unpkg to jsdelivr since fetching the unpkg url using node fetch fails (maybe there's a robots.txt?).Depends on #7580.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is