Avoid draw API warning if the current backend does not have implementation #7744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qjia7
reviewed
Jun 8, 2023
tfjs-core/src/ops/browser.ts
Outdated
| 'Please try tf.browser.draw instead.'); | ||
| hasToPixelsWarned = true; | ||
| const backendName = getBackend(); | ||
| if (backendName !== 'webgl' && backendName !== 'webgpu') { |
There was a problem hiding this comment.
How about checking like below? Then we don't need to revisit it anymore.
const kernel = getKernel(Draw, ENGINE.backendName);
if (kernel != null) {
console.warn(
'tf.browser.toPixels is not efficient to draw tensor on canvas. ' +
'Please try tf.browser.draw instead.');
}
There was a problem hiding this comment.
Nice catch, thanks!
mattsoulanille
approved these changes
Jun 8, 2023
Linchenn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Draw API on WebGL and WebGPU backends are in progress, we could avoid the warning until they are launched.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.