-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tokenizer base class. #7757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I have a few minor changes, and some longer comments on some things I've discovered about BytePairTokenizer.
Co-authored-by: Matthew Soulanille <matthew@soulanille.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple of nits.
Co-authored-by: Matthew Soulanille <matthew@soulanille.net>
Add the Tokenizer base class from which BytePairEncoding and other future Tokenizers will inherit from.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.