BPE Detokenize #7788
Merged
BPE Detokenize #7788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthew Soulanille <matthew@soulanille.net>
Co-authored-by: Matthew Soulanille <matthew@soulanille.net>
|
LGTM once #7780 is merged. |
mattsoulanille
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the detokenize method for BytePairEncoding.
Note:
Kera’s detokenize() currently uses Python’s byte strings (b’my text here’) so their implementation is a bit different than what I have here. I’ve added a test case for now that works on both implementations, highlighting that
detokenize(tokenize(input))should equal the originalinput, but there might be something I’m missing due to the omitted part of the implementation. This can be pushed off to the clean up PR in the future, but should be okay for now.