[gpt2pre 3] Preprocessor Layer #7794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks good, but can we have a simple test for this where it loads either a fake tokenizer (which you define and register in the test code) or the BytePairTokenizer? The reason for this is because it has a non-trivial fromConfig function that initializes an additional layer.
Dedongala
added a commit
that referenced
this pull request
Jul 18, 2023
* [gpt2pre 3] Preprocessor Layer (#7794) * Add Preprocessor layer * Remove uneeded args * Use LayerArgs * Remove import from src * Add fromConfig method * Serialize tokenizer properly * Add test cases for preprocessor * Preprocessor tests with no set tokenizer --------- Co-authored-by: Linchenn <40653845+Linchenn@users.noreply.github.com> * Remove npm proxy for @tensorflow scoped packages See #7557 --------- Co-authored-by: Piero F Orderique <45519489+pforderique@users.noreply.github.com> Co-authored-by: Linchenn <40653845+Linchenn@users.noreply.github.com> Co-authored-by: Matthew Soulanille <msoulanille@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the base layer for processor layers, such as the GPT2 Preprocessor layer.
Update:
Some methods were left unimplemented and are pending discussionBased on discussion with @mattsoulanille,
presetswas removed, andfromConfigandgetConfigwas implemented instead.