Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gpt2pre 2] GPT2 Tokenizer Class #7806

Merged
merged 2 commits into from
Jul 11, 2023
Merged

[gpt2pre 2] GPT2 Tokenizer Class #7806

merged 2 commits into from
Jul 11, 2023

Conversation

pforderique
Copy link
Contributor

Implements the GPT2Tokenizer that extends BytePairEncoding.

This is a standalone PR with no dependencies or implementation followups.

GPT2Tokenizer will be used by GPT2Preprocessor in a future PR.

NOTE:
This class does not implement presets() as discussed earlier this week.

@pforderique pforderique mentioned this pull request Jul 10, 2023
Merged
mattsoulanille
mattsoulanille approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Linchenn
Linchenn approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@Linchenn Linchenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pforderique pforderique merged commit 5c3f76e into tensorflow:master Jul 11, 2023
2 checks passed
@pforderique pforderique deleted the gpt2-tokenizer branch July 11, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsoulanille mattsoulanille mattsoulanille approved these changes

@Linchenn Linchenn Linchenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pforderique @mattsoulanille @Linchenn