Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gpt2bb impl] Backbone class (1/1) #7838

Merged
merged 4 commits into from
Jul 13, 2023
Merged

[gpt2bb impl] Backbone class (1/1) #7838

merged 4 commits into from
Jul 13, 2023

Conversation

pforderique
Copy link
Contributor

@pforderique pforderique commented Jul 12, 2023 •
edited

Implements the Backbone class.

I am not sure how this class is supposed to be deserialized from just the info that getConfig returns since ContainerArgs (needed by the super class LayersModel) requires inputs and outputs fields which are SymbolicTensors, but it seems that GPT2Backbone initializes the parent class with different types.

@Linchenn Linchenn requested a review from fengwuyao July 12, 2023 23:11
mattsoulanille
mattsoulanille approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We can figure out how getConfig will work when we implement it.

@pforderique pforderique merged commit 83ee8b9 into tensorflow:master Jul 13, 2023
2 checks passed
@pforderique pforderique deleted the backbone branch July 13, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsoulanille mattsoulanille mattsoulanille approved these changes

@Linchenn Linchenn Linchenn approved these changes

@fengwuyao fengwuyao Awaiting requested review from fengwuyao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pforderique @mattsoulanille @Linchenn