Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gpt2bb spec] PositionEmedding layer #7839

Merged
merged 4 commits into from
Jul 13, 2023
Merged

[gpt2bb spec] PositionEmedding layer #7839

merged 4 commits into from
Jul 13, 2023

Conversation

pforderique
Copy link
Contributor

@pforderique pforderique commented Jul 12, 2023 •
edited

Add PositionEmbedding specs.

Linchenn
Linchenn approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@Linchenn Linchenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a nit.

tfjs-layers/src/layers/nlp/modeling/position_embedding.ts Outdated Show resolved Hide resolved
@pforderique pforderique merged commit 925e2ef into tensorflow:master Jul 13, 2023
2 checks passed
@pforderique pforderique deleted the spec-positionembedding branch July 13, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsoulanille mattsoulanille mattsoulanille approved these changes

@Linchenn Linchenn Linchenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pforderique @mattsoulanille @Linchenn