Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase epsilon values for draw tests #7841

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Conversation

Linchenn
Copy link
Collaborator

In the browserstack tests for Firefox 90.0 (Mac OS 10.13), the difference between source values and 'draw+read back' could be 6.0, while the codes are correct. This PR increases the epsilon values from 3.0 to 6.0.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

@Linchenn Linchenn requested a review from qjia7 July 13, 2023 17:01
@Linchenn Linchenn requested a review from fengwuyao July 13, 2023 17:03
Copy link
Collaborator

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Linchenn Linchenn enabled auto-merge (squash) July 14, 2023 17:13
@Linchenn Linchenn merged commit 022c3db into tensorflow:master Jul 14, 2023
2 checks passed
@Linchenn Linchenn deleted the fixdrawcmp branch July 14, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants