Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for offline planning of variable tensors #1676

Merged
merged 6 commits into from Feb 13, 2023
Merged

Add support for offline planning of variable tensors #1676

merged 6 commits into from Feb 13, 2023

Conversation

mansnils
Copy link
Contributor

@mansnils mansnils commented Jan 20, 2023 •
edited by advaitjain

  • New assumption that offline planner (in this case Vela) supports variable tensors
  • Move variable tensor allocation in the online planner to later in the memory plannign phase so that we have the opportunity to get the offfsets from the offline planner for these as well.

Co-authored-by: Fredrik Svedberg fredrik.svedberg@arm.com

BUG=Offline planner does not support variable tensors.

@mansnils mansnils requested a review from a team as a code owner January 20, 2023 14:36
@fresve-arm @mansnils
Add support for offline planning of variable tensors
08e8375 
Co-authored-by: Fredrik Svedberg <fredrik.svedberg@arm.com>
Co-authored-by: Måns Nilsson <mans.nilsson@arm.com>
@TFLM-bot TFLM-bot removed the ci:run label Jan 20, 2023
@mansnils mansnils added the ci:run label Feb 1, 2023
@TFLM-bot TFLM-bot removed the ci:run label Feb 1, 2023
advaitjain
advaitjain requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@advaitjain advaitjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry missed a few small things in my last review around not having default arguments.

tensorflow/lite/micro/micro_allocator.h Outdated Show resolved Hide resolved
tensorflow/lite/micro/micro_allocator.h Show resolved Hide resolved
tensorflow/lite/micro/recording_micro_allocator.h Outdated Show resolved Hide resolved
@mansnils mansnils added the ci:run label Feb 2, 2023
@TFLM-bot TFLM-bot removed the ci:run label Feb 2, 2023
@mansnils
Copy link
Contributor Author

mansnils commented Feb 8, 2023

All comments resolved and ready for review.

@mergify mergify bot merged commit 58aa983 into tensorflow:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@advaitjain advaitjain advaitjain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mansnils @advaitjain @TFLM-bot @fresve-arm