Implement new MessagePack-encoded table slices #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
changed the base branch from
master
to
epic/flatbuffers-persistence-table-slices
10 tasks
This prepares the `table_slice_builder` for the upcoming changes by doing some much-needed housecleaning.
Much like the `table_slice_builder`, some cruft accumulated on `msgpack_table_slice_builder` that needed to be removed.
dominiklohmann
force-pushed
the
topic/table-slice-msgpack
branch
from
8ccc15d
to
301e5a4
Compare
tobim
reviewed
Nov 10, 2020
dominiklohmann
force-pushed
the
topic/table-slice-msgpack
branch
from
a019ef8
to
5e0b7c3
Compare
The `table_slice::inspect` function must go through the constructor that handles the instance counting when loading table slices from a `caf::message`.
The offset being in the `table_slice` encoding-specific FlatBuffers tables was the only reason why we required support for mutable FlatBuffers. This commit changes `table_slice` to hold the offset in-memory. The offset is now assigned by the importer on import and by the segment on lookup.
The FlatBuffers API guarantees that the encoding pointers are not `nullptr`, so we might as well dereference them in the visitor function already.
dominiklohmann
force-pushed
the
topic/table-slice-msgpack
branch
from
6a0b0ee
to
3693e29
Compare
3 tasks
3 tasks
tobim
approved these changes
Nov 12, 2020
Performance experiments with the new table_slice API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
The fifth PR to be merged into #1140. This one re-implements MessagePack-encoded table slices to use FlatBuffers directly.
📝 Checklist
🎯 Review Instructions
Commit-by-commit feels best.