-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move options from format to the import subcommand #1354
Conversation
I guess it would be a good idea to do the same for the sink options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quoting myself from the story:
I have another thought on this: Consider this file:
vast: import: pcap: interface: en0 read: path/to/file.pcapWhat does
vast import pcap
do in this case?Similarly, consider this currently valid file:
vast: import: suricata: read: path/to/eve.json zeek read: path/to/conn.log
How would you express this with your proposed changes?
I did not look at the code yet, but I would like to see these questions answered before we merge a change like this.
This is not different from vast:
import:
pcap:
interface: en0
read: path/to/file.pcap The pcap implementation prefers the interface key in both cases.
While valid, the utility of such a config is extremely limited. If we really want to allow users to specify their imports declaratively they should either have a separate config file per import process or this has to become a list in a unified config file. |
Reasoning checks out. I think it'd be nice if this same PR can also make the changes on the export side so it stays symmetrical. |
52a2b99
to
34efc36
Compare
Will do after the rebase on top of #1356. |
c7b0df0
to
87013c3
Compare
The options `listen`, `read`, `schema`, `schema-file`, `type`, and `uds` can from now on be supplied to the `import` command directly. They can still be used after the format subcommand, but that usage is deprecated.
87013c3
to
d686396
Compare
Co-authored-by: Dominik Lohmann <mail@dominiklohmann.de>
📔 Description
The options
listen
,read
,schema
,schema-file
,type
, anduds
can from now on be supplied to theimport
command directly. They can still be used after the format subcommand, but that usage is deprecated.📝 Checklist
🎯 Review Instructions
By commit.